Allow hiding handler error

[tlienart]

Hello,

These lines:

HTTP.jl/src/Servers.jl

Lines 453 to 456 in 32e84aa

	# The remote can close the stream whenever it wants to, but there's nothing
	# anyone can do about it on this side. No reason to log an error in that case.
	level = e isa Base.IOError && !isopen(c) ? Logging.Debug : Logging.Error
	@logmsgv 1 level "handle_connection handler error" exception=(e, stacktrace(catch_backtrace()))

can cause the kind of error message in LiveServer (see details below). It doesn't stop the server (good) but the error message is obscure and the user cannot do anything about it + it doesn't affect them. Could we have a toggle to hide this error message? something that would allow me to write in LS

req_handler = HTTP.streamhandler(show_errors=false) do req
  ...
end

so that the handle_connection function doesn't apply the @logmsgv ... line.

Thanks

Details

┌ LogLevel(1999): handle_connection handler error
│   exception =
│    IOError: write: broken pipe (EPIPE)
│    Stacktrace:
│      [1] uv_write(s::Sockets.TCPSocket, p::Ptr{UInt8}, n::UInt64)
│        @ Base ./stream.jl:1064
│      [2] unsafe_write(s::Sockets.TCPSocket, p::Ptr{UInt8}, n::UInt64)
│        @ Base ./stream.jl:1118
│      [3] unsafe_write(c::HTTP.ConnectionPool.Connection, p::Ptr{UInt8}, n::UInt64)
│        @ HTTP.ConnectionPool ~/.julia/packages/HTTP/VAOuj/src/ConnectionPool.jl:105
│      [4] unsafe_write(http::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.ConnectionPool.Connection}, p::Ptr{UInt8}, n::UInt64)
│        @ HTTP.Streams ~/.julia/packages/HTTP/VAOuj/src/Streams.jl:94
│      [5] write(io::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.ConnectionPool.Connection}, s::String)
│        @ Base ./strings/io.jl:244
│      [6] write(io::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.ConnectionPool.Connection}, s::Base.CodeUnits{UInt8, String})
│        @ Base ./strings/basic.jl:758
│      [7] (::HTTP.Handlers.var"#1#2"{LiveServer.var"#16#20"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}})(stream::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.ConnectionPool.Connection})
│        @ HTTP.Handlers ~/.julia/packages/HTTP/VAOuj/src/Handlers.jl:61
│      [8] (::LiveServer.var"#25#26"{HTTP.Handlers.var"#1#2"{LiveServer.var"#16#20"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}}})(http::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.ConnectionPool.Connection})
│        @ LiveServer ~/.julia/packages/LiveServer/t2p5e/src/server.jl:606
│      [9] #invokelatest#2
│        @ ./essentials.jl:729 [inlined]
│     [10] invokelatest
│        @ ./essentials.jl:726 [inlined]
│     [11] handle_connection(f::Function, c::HTTP.ConnectionPool.Connection, listener::HTTP.Servers.Listener{Nothing, Sockets.TCPServer}, readtimeout::Int64, access_log::Nothing)
│        @ HTTP.Servers ~/.julia/packages/HTTP/VAOuj/src/Servers.jl:442
│     [12] (::HTTP.Servers.var"#16#17"{LiveServer.var"#25#26"{HTTP.Handlers.var"#1#2"{LiveServer.var"#16#20"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}}}, HTTP.Servers.Listener{Nothing, Sockets.TCPServer}, Set{HTTP.ConnectionPool.Connection}, Int64, Nothing, Base.Semaphore, HTTP.ConnectionPool.Connection})()
│        @ HTTP.Servers ./task.jl:484
└ @ HTTP.Servers ~/.julia/packages/HTTP/VAOuj/src/Servers.jl:456

[quinnj]

Yeah, this is actually a LoggingExtras.jl issue I need to follow up on/fix. The idea is that this log message should require a verbosity of at least 1 to be logged, but because it's an ERROR log, it's getting logged regardless.

[tlienart]

Sorry to bring this back, but I'm still seeing the same problem as above.

Is there an argument that needs to be passed to HTTP.listen! or set somewhere so that this @logmsgv gets silenced as I'd like it to be? I'm currently calling it with these lines:

    try
        server = HTTP.listen!(host, port; readtimeout=0) do http::HTTP.Stream
            if HTTP.WebSockets.isupgrade(http.message)
                # upgrade to websocket and add to list of viewers and keep open
                # until written to
                HTTP.WebSockets.upgrade(ws_tracker, http)
            else
                # handle HTTP request
                return req_handler(http)
            end
        end
        return server, port
    catch

https://github.com/tlienart/LiveServer.jl/blob/09a29e71a317f8ed05b125e78ca2839332c33894/src/server.jl#L695-L707

Failing that, could some sort of toggle be added so that that @logmsgv can be silenced?

thanks!

Note: it may be that we're running into something you commented on: #382 (comment) because we do indeed ping websockets in @async blocks e.g.:

# send update message to all viewers
@sync for wsᵢ in ws_to_update_and_close
    isopen(wsᵢ.io) && @async begin
        try
            HTTP.WebSockets.send(wsᵢ, "update")
        catch
        end
    end
end

Full stacktrace (this is with latest HTTP btw)

┌ Error: handle_connection handler error
│   exception =
│    IOError: write: broken pipe (EPIPE)
│    Stacktrace:
│      [1] uv_write(s::Sockets.TCPSocket, p::Ptr{UInt8}, n::UInt64)
│        @ Base ./stream.jl:1066
│      [2] unsafe_write(s::Sockets.TCPSocket, p::Ptr{UInt8}, n::UInt64)
│        @ Base ./stream.jl:1120
│      [3] unsafe_write
│        @ ~/.julia/packages/HTTP/nn2yB/src/Connections.jl:129 [inlined]
│      [4] unsafe_write(http::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}}, p::Ptr{UInt8}, n::UInt64)
│        @ HTTP.Streams ~/.julia/packages/HTTP/nn2yB/src/Streams.jl:93
│      [5] write
│        @ ./strings/io.jl:244 [inlined]
│      [6] write(io::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}}, s::Base.CodeUnits{UInt8, String})
│        @ Base ./strings/basic.jl:761
│      [7] (::HTTP.Handlers.var"#1#2"{LiveServer.var"#22#26"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}})(stream::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}})
│        @ HTTP.Handlers ~/.julia/packages/HTTP/nn2yB/src/Handlers.jl:61
│      [8] (::LiveServer.var"#31#32"{HTTP.Handlers.var"#1#2"{LiveServer.var"#22#26"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}}})(http::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}})
│        @ LiveServer ~/.julia/dev/LiveServer/src/server.jl:703
│      [9] #invokelatest#2
│        @ ./essentials.jl:816 [inlined]
│     [10] invokelatest
│        @ ./essentials.jl:813 [inlined]
│     [11] handle_connection(f::Function, c::HTTP.Connections.Connection{Sockets.TCPSocket}, listener::HTTP.Servers.Listener{Nothing, Sockets.TCPServer}, readtimeout::Int64, access_log::Nothing)
│        @ HTTP.Servers ~/.julia/packages/HTTP/nn2yB/src/Servers.jl:447
│     [12] macro expansion
│        @ ~/.julia/packages/HTTP/nn2yB/src/Servers.jl:385 [inlined]
│     [13] (::HTTP.Servers.var"#16#17"{LiveServer.var"#31#32"{HTTP.Handlers.var"#1#2"{LiveServer.var"#22#26"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}}}, HTTP.Servers.Listener{Nothing, Sockets.TCPServer}, Set{HTTP.Connections.Connection}, Int64, Nothing, Base.Semaphore, HTTP.Connections.Connection{Sockets.TCPSocket}})()
│        @ HTTP.Servers ./task.jl:514
└ @ HTTP.Servers ~/.julia/packages/HTTP/nn2yB/src/Servers.jl:461
┌ Error: handle_connection handler error
│   exception =
│    IOError: write: broken pipe (EPIPE)
│    Stacktrace:
│      [1] uv_write(s::Sockets.TCPSocket, p::Ptr{UInt8}, n::UInt64)
│        @ Base ./stream.jl:1066
│      [2] unsafe_write(s::Sockets.TCPSocket, p::Ptr{UInt8}, n::UInt64)
│        @ Base ./stream.jl:1120
│      [3] unsafe_write
│        @ ~/.julia/packages/HTTP/nn2yB/src/Connections.jl:129 [inlined]
│      [4] unsafe_write(http::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}}, p::Ptr{UInt8}, n::UInt64)
│        @ HTTP.Streams ~/.julia/packages/HTTP/nn2yB/src/Streams.jl:93
│      [5] write
│        @ ./strings/io.jl:244 [inlined]
│      [6] write(io::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}}, s::Base.CodeUnits{UInt8, String})
│        @ Base ./strings/basic.jl:761
│      [7] (::HTTP.Handlers.var"#1#2"{LiveServer.var"#22#26"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}})(stream::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}})
│        @ HTTP.Handlers ~/.julia/packages/HTTP/nn2yB/src/Handlers.jl:61
│      [8] (::LiveServer.var"#31#32"{HTTP.Handlers.var"#1#2"{LiveServer.var"#22#26"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}}})(http::HTTP.Streams.Stream{HTTP.Messages.Request, HTTP.Connections.Connection{Sockets.TCPSocket}})
│        @ LiveServer ~/.julia/dev/LiveServer/src/server.jl:703
│      [9] #invokelatest#2
│        @ ./essentials.jl:816 [inlined]
│     [10] invokelatest
│        @ ./essentials.jl:813 [inlined]
│     [11] handle_connection(f::Function, c::HTTP.Connections.Connection{Sockets.TCPSocket}, listener::HTTP.Servers.Listener{Nothing, Sockets.TCPServer}, readtimeout::Int64, access_log::Nothing)
│        @ HTTP.Servers ~/.julia/packages/HTTP/nn2yB/src/Servers.jl:447
│     [12] macro expansion
│        @ ~/.julia/packages/HTTP/nn2yB/src/Servers.jl:385 [inlined]
│     [13] (::HTTP.Servers.var"#16#17"{LiveServer.var"#31#32"{HTTP.Handlers.var"#1#2"{LiveServer.var"#22#26"{typeof(identity), Bool, Bool, LiveServer.SimpleWatcher}}}, HTTP.Servers.Listener{Nothing, Sockets.TCPServer}, Set{HTTP.Connections.Connection}, Int64, Nothing, Base.Semaphore, HTTP.Connections.Connection{Sockets.TCPSocket}})()
│        @ HTTP.Servers ./task.jl:514
└ @ HTTP.Servers ~/.julia/packages/HTTP/nn2yB/src/Servers.jl:461