Skip to content

Fix TZ data parsing for Julia 0.6 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshbode wants to merge 1 commit into from
Closed

Fix TZ data parsing for Julia 0.6 #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/tzdata/compile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,24 @@ if isdefined(Base.Dates, :parse_components)
else
# Note: On older versions of Julia this will sort the Periods. Since our DateFormat
# is already in reverse sorted order there shouldn't be a difference.
function parse_components(str::AbstractString, df::DateFormat)
convert(Array{Any}, Dates.parse(str, df))
if method_exists(parse, Tuple{Type{TimeType}, AbstractString, Base.Dates.DateFormat})
# 0.6
function parse_components(str::AbstractString, df::DateFormat)
# wrap to next day if hour is 24
wrap = ismatch(r" 24:00$", str)
if wrap
str = replace(str, r" 24:00$", " 00:00")
end
x = Dates.parse(DateTime, str, df)
if wrap
x += Day(1)
end
[Year(x), Month(x), Day(x), Hour(x), Minute(x), Second(x)]
end
else
function parse_components(str::AbstractString, df::DateFormat)
convert(Array{Any}, Dates.parse(str, df))
end
end
end

Expand Down