Add ForwardDiff regression test for invquad/quad (issue #99)#240
Open
devmotion wants to merge 1 commit into
Open
Add ForwardDiff regression test for invquad/quad (issue #99)#240devmotion wants to merge 1 commit into
devmotion wants to merge 1 commit into
Conversation
Pins both halves of the fix for the invquad/quad performance regression reported in #99: the partials are differentiated correctly, and the allocation stays O(n * #partials) instead of copying or promoting the Cholesky factor to `Dual` (which was O(n^2 * #partials)). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 94.78% 94.84% +0.05%
==========================================
Files 11 11
Lines 805 814 +9
==========================================
+ Hits 763 772 +9
Misses 42 42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for the
invquad/quadperformance regression reported in #99.The regression (accessing
M.chol.L/.U, which copies the Cholesky factor, O(n²)) was fixed by switching to the lazychol_lower/chol_upperfactors. This test pins both halves of that fix:∇ invquad(A, x) = 2 A⁻¹xand∇ quad(A, x) = 2 A xviaForwardDiff.gradient.Dual{p}input the work stays O(n·#partials) (a single result vector), rather than copying/promoting the factor toDual(O(n²·#partials)).🤖 Generated with Claude Code