Upgrade to StatsBase v0.34#59
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 7 7
Lines 659 659
=======================================
Hits 519 519
Misses 140 140
☔ View full report in Codecov by Sentry. |
|
Hi @ararslan , would you mind taking a look and merging? I need this for a couple of downstream packages. |
|
It seems worthwhile to me to replace the uses of those type aliases with their definitions in the same manner as JuliaStats/StatsBase.jl#840 rather than adding a new dependency on a package that defines them. |
|
I guess I missed your sarcasm here JuliaStats/StatsBase.jl#840 (review) |
|
Ah, my apologies, the |
|
No worries. I made those changes. Hopefully good to go. |
ararslan
left a comment
There was a problem hiding this comment.
LGTM with a minor tweak to compatibility bounds
Co-authored-by: Alex Arslan <ararslan@comcast.net>
|
Registering here: JuliaRegistries/General#89850 Thanks! |
|
Thanks for the quick turnaround! |
JuliaStats/StatsBase.jl#840
Also adding a CompatHelper action
Bumps MLBase version so it can be tagged