update readme with better fitting interpolation#45
Merged
andreasnoack merged 2 commits intoJuliaStats:masterfrom Nov 10, 2021
Merged
update readme with better fitting interpolation#45andreasnoack merged 2 commits intoJuliaStats:masterfrom
andreasnoack merged 2 commits intoJuliaStats:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 91.66% 92.26% +0.59%
==========================================
Files 2 2
Lines 168 168
==========================================
+ Hits 154 155 +1
+ Misses 14 13 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
No interest? |
Member
|
I agree that the example doesn't look too good so I'm fine with adjusting the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted here, the current example in the readme is actually kind of a bad interpolation on the lower end. Seems worth it to highlight the strengths, so this tweaks the
spanargument to make it look better. Also I just embedded the image (30kb) in the repo which seems less prone to breaking in the future. This isRandom.seed!(1)w/ Julia 1.6 should anyone ever want to reproduce exactly.