Conversation
The queues are long since resources are more limited, and this package has no platform-specific code or binary dependencies which make testing on multiple systems worthwhile.
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage ? 88.74%
=========================================
Files ? 2
Lines ? 151
Branches ? 0
=========================================
Hits ? 134
Misses ? 17
Partials ? 0
Continue to review full report at Codecov.
|
nalimilan
approved these changes
Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've separated things out into distinct commits:
loessdefinition, which fixes Integer input not accepted #27.__precompile__, since it's the default.DimensionMismatchinstead oferrorwhen checking dimension consistency.