Fix dropcollinear issue with an empty nullmodel#73
Merged
AsafManela merged 2 commits intoJuliaStats:masterfrom Nov 29, 2022
Merged
Fix dropcollinear issue with an empty nullmodel#73AsafManela merged 2 commits intoJuliaStats:masterfrom
AsafManela merged 2 commits intoJuliaStats:masterfrom
Conversation
…ives very large rank otherwise)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with GLM v1.8.1 fit() passes dropcollinear=true by default.
Lasso uses GLM.fit() to build a nullmodel with unregularized X variables.
When this matrix had zero columns, dropcollinear would check for its rank and get a very large number causing issues.
We now do not dropcollinear when size(X,2)==0.
Because the dropping of collinear unregularized columns is a change in behavior, I am bumping up the version accordingly.