Skip to content

bump DSP compat to 0.7; fix csv-to-matrix function to DataFrames 1#59

Merged
AsafManela merged 1 commit intomasterfrom
dfk/dsp7
Jun 3, 2021
Merged

bump DSP compat to 0.7; fix csv-to-matrix function to DataFrames 1#59
AsafManela merged 1 commit intomasterfrom
dfk/dsp7

Conversation

@kleinschmidt
Copy link
Member

DSP 0.7 was released recently, with changes that don't affect the use of filt! here AFAIK.

This also fixes the function to convert a dataframe into a matrix since it was erroring with DataFrames 1.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #59 (d8f6985) into master (ea74151) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   92.45%   92.52%   +0.06%     
==========================================
  Files           8        8              
  Lines        1114     1111       -3     
==========================================
- Hits         1030     1028       -2     
+ Misses         84       83       -1     
Impacted Files Coverage Δ
src/Lasso.jl 90.69% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea74151...d8f6985. Read the comment docs.

@AsafManela AsafManela merged commit e097e8f into master Jun 3, 2021
@AsafManela
Copy link
Collaborator

Thank you!

@AsafManela AsafManela deleted the dfk/dsp7 branch June 3, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants