Skip to content

Add test/Project.toml#35

Open
arnavk23 wants to merge 2 commits intoJuliaSmoothOptimizers:mainfrom
arnavk23:add-test-project-toml
Open

Add test/Project.toml#35
arnavk23 wants to merge 2 commits intoJuliaSmoothOptimizers:mainfrom
arnavk23:add-test-project-toml

Conversation

@arnavk23
Copy link

@arnavk23 arnavk23 commented Dec 6, 2025

Fixes #29
Fixes #11

Copilot AI review requested due to automatic review settings December 6, 2025 12:09
@arnavk23
Copy link
Author

arnavk23 commented Dec 6, 2025

@tmigot As currently there are no tests in the runtests.jl, added this according to the current file.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a test/Project.toml file to properly manage test dependencies following modern Julia best practices. This addresses issues #29 and #11 by creating a separate test environment that isolates test dependencies from the main package dependencies.

  • Adds test/Project.toml with test-specific dependencies (JSOTemplate and Test)
  • Follows the same pattern already used in docs/Project.toml for documentation dependencies
  • UUIDs correctly match those defined in the main Project.toml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove

[extras]
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test"]

from the main Project.toml
https://github.com/JuliaSmoothOptimizers/JSOTemplate.jl/blob/main/Project.toml

@arnavk23 arnavk23 requested a review from tmigot December 17, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test/Project.toml Add test/Project.toml

3 participants