Create JSOTemplate compliance workflow#23
Conversation
|
@abelsiqueira |
I'm fine with that. I don't remember if we have limits in CIRRUS. Is the Apple M1 testing included? Can you create a PR updating the cirrus here, please? |
Yes, the Apple M1 testing is included and we don't have limits in CirrusCI. |
60fd312 to
2df24fe
Compare
|
I've rebased and added Aqua, Invalidations, and cirrus |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=========================================
+ Coverage 0 11.11% +11.11%
=========================================
Files 0 2 +2
Lines 0 9 +9
=========================================
+ Hits 0 1 +1
- Misses 0 8 +8
☔ View full report in Codecov by Sentry. |
86376ac to
b0585ac
Compare
|
@dpo, @tmigot, @amontoison, I am ready to merge this. There are limitations, but this provides a basic structure to change, e.g., CI.yml across many repos. |
|
PS. @amontoison, do you know what are the ARMv8 failures? |
dpo
left a comment
There was a problem hiding this comment.
Looks good to me, but where is check_and_fix_compliance implemented?
It seems that Julia 1.9 was not built for this platform. Great job Abel! |
|
Thank you for the reviews. |
tmigot
left a comment
There was a problem hiding this comment.
I like the idea, thanks @abelsiqueira !
cf. @dpo, @tmigot, @amontoison
This PR creates a workflow that runs daily and checks that a few files are the same as the ones here:
.JuliaFormatter.toml.github/workflows/,CI.yml,CompatHelper.yml,Formatter.yml,Register.yml,TagBot.ymlIt also changed the case of the files to CamelCase, so it is uniform.
This workflow can also be triggered manually.
If there are differences, then a PR is created on that package to fix it.
If there were already PRs from compliance, then the old ones are closed.
This was tested on a single repository (JuliaSmoothOptimizers/DerivativeFreeSolvers.jl#44) and it took a lot of tries and small fixes. So it might lead to a PR hell, which is why I created a PR for review before merging and triggering it.
Along with #18, #19, and #20, it should revamp the workflows of all JSO packages.