fix ampl_meta re-exporting NLPModelMeta.get_* specializations#166
Merged
amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom Feb 23, 2026
Merged
Conversation
Contributor
Author
|
@amontoison could you also take a look at this one :) not urgent but is also quite a small bugfix. |
Member
|
If all tests passed, I will do a patch release :) |
amontoison
approved these changes
Feb 23, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
========================================
Coverage 95.41% 95.42%
========================================
Files 3 6 +3
Lines 567 699 +132
========================================
+ Hits 541 667 +126
- Misses 26 32 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
AmplNLReaderre-exports over NLPModelsget_*methods. This means you have to use the fully qualified names if you import bothNLPModelsandAmplNLReaderwhich I think is unintended.