Skip to content

fix ampl_meta re-exporting NLPModelMeta.get_* specializations#166

Merged
amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom
apozharski:ap/fix-getters
Feb 23, 2026
Merged

fix ampl_meta re-exporting NLPModelMeta.get_* specializations#166
amontoison merged 1 commit intoJuliaSmoothOptimizers:mainfrom
apozharski:ap/fix-getters

Conversation

@apozharski
Copy link
Contributor

Currently AmplNLReader re-exports over NLPModels get_* methods. This means you have to use the fully qualified names if you import both NLPModels and AmplNLReader which I think is unintended.

@apozharski
Copy link
Contributor Author

@amontoison could you also take a look at this one :) not urgent but is also quite a small bugfix.

@amontoison
Copy link
Member

If all tests passed, I will do a patch release :)

@amontoison amontoison merged commit f631e0b into JuliaSmoothOptimizers:main Feb 23, 2026
15 checks passed
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.42%. Comparing base (de2f453) to head (4e7daa9).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/ampl_utils.jl 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #166    +/-   ##
========================================
  Coverage   95.41%   95.42%            
========================================
  Files           3        6     +3     
  Lines         567      699   +132     
========================================
+ Hits          541      667   +126     
- Misses         26       32     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants