Integer -> Union{StaticInt,Int} and return Int for first/last #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 1 1
Lines 36 36
=======================================
Hits 18 18
Misses 18 18
Continue to review full report at Codecov.
|
chriselrod
approved these changes
Jun 3, 2022
| @inline Base.first(r::AbstractCloseOpen{StaticInt{F}}) where {F} = F | ||
| @inline Base.step(::AbstractCloseOpen) = 1 | ||
| @inline Base.last(r::AbstractCloseOpen{<:Union{Int,StaticInt},I}) where {I} = getfield(r,:upper) - 1 | ||
| @inline Base.last(r::AbstractCloseOpen{<:Union{Int,StaticInt},StaticInt{L}}) where {L} = L - 1 |
Member
There was a problem hiding this comment.
Note that this line returned a StaticInt before, but now returns an Int.
I do think that's fine though, Base methods should probably only be returning Int.
Member
Author
There was a problem hiding this comment.
That was intentional because of the issue mentioned here SciML/Static.jl#64 (comment). It was the quickest fix but if that's a no go we could look for other solutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.