Skip to content

fix: head is incorrect for get_pull_requests #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: head is incorrect for get_pull_requests #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Registrator"
uuid = "4418983a-e44d-11e8-3aec-9789530b3b3e"
authors = ["Stefan Karpinski <[email protected]>"]
version = "1.9.2"
version = "1.9.3"

[deps]
AutoHashEquals = "15f4f7f2-30c1-5605-9d31-71845cf9641f"
Expand Down
4 changes: 2 additions & 2 deletions src/webui/gitutils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ function make_registration_request(
repo = r.repo.name
base = r.repo.default_branch
fork_owner = REGISTRY[].fork_repo.owner.login
head = owner == fork_owner ? branch : string(fork_owner, ":", branch)
head = string(fork_owner, ":", branch)
try
result, _ = create_pull_request(
r.forge, owner, repo;
Expand All @@ -349,7 +349,7 @@ function make_registration_request(
val, _ = get_pull_requests(r.forge, owner, repo; head=head, base=base, state="open")

if length(val) != 1
@error "Expected to find one open pull request created from a previous registration attempt but got $(length(val)) pull requests" owner=owner repo=repo base=base head=branch exception=ex,catch_backtrace()
@error "Expected to find one open pull request created from a previous registration attempt but got $(length(val)) pull requests" owner=owner repo=repo base=base head=head exception=ex,catch_backtrace()
return nothing, nothing
end

Expand Down