Avoid recursion during error handling #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current master,
self.sprintandself.showerrorare used to handle errors:pyjulia/julia/core.py
Lines 457 to 476 in e617ad9
They are set at the end of
api.Julia.__init__pyjulia/julia/core.py
Lines 432 to 433 in e617ad9
but
self._call(u"using PyCall")has to be called before this to initialize pyjulia in the first place:pyjulia/julia/core.py
Line 416 in e617ad9
The error case in
self._call(u"using PyCall")was actually handled incheck_exceptionwith theexcept AttributeErrorbranch. However, my PR #162 just got pulled broke this horribly since accessingself.sprintinvokesLegacyJulia.__getattr__which then in turn tries to initializeapi.Julia. There are several ways to fix it but the first thing we can do is to avoid inheritance and separate out the "magic" objectapi.LegacyJuliafrom the coreapi.Julia.It fixes the error I mentioned in #175 (but not the issue itself).