Skip to content

Conversation

@tkf
Copy link
Member Author

tkf commented Sep 21, 2018

There is one failure in AppVeyor due to network problem https://ci.appveyor.com/project/StevenGJohnson/conda-jl/build/1.0.125

Except for that, it looks like it's working.

# * https://github.com/JuliaLang/IJulia.jl/issues/739
# * https://github.com/ContinuumIO/anaconda-issues/issues/10082
# * https://github.com/conda/conda/issues/7789
res = "https://repo.continuum.io/miniconda/Miniconda$(MINICONDA_VERSION)-4.5.4-"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main part of this PR is this if block. Everything else is test/CI tweaks.

tkf added a commit to tkf/PyCall.jl that referenced this pull request Sep 21, 2018
@tkf
Copy link
Member Author

tkf commented Sep 21, 2018

It works with PyCall: JuliaPy/PyCall.jl#577

@stevengj
Copy link
Member

Okay. We can just take out this special case when the issue is fixed upstream. (Soon, I hope?)

@tkf
Copy link
Member Author

tkf commented Sep 22, 2018

I hope so. Let's track it in #125.

@stevengj
Copy link
Member

I forgot we did this! It's been two years, probably time to revert this patch!

In particular, it seems like Python 3.6 with breaks Tornado on Windows these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants