-
Notifications
You must be signed in to change notification settings - Fork 645
PoCL: Bump to v7.1 and reenable Float16 support #12219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like we need a newer GCC version for Float16 support: |
be24884 to
2444b91
Compare
|
Also see pocl/pocl#1943 (reply in thread); that may be a better fix rather than reverting the commit. |
Also contains the workaround proposed in pocl/pocl#1943 (reply in thread)
|
Hmm, now RISC-V is failing, not sure how to fix that |
is relevant? |
|
I don't think so. This was the case in https://buildkite.com/julialang/yggdrasil/builds/23892#0199b4b9-a462-4afb-924b-d8f1011e0701/1099-1560 as well and that job passed |
75d49d0 to
da0e334
Compare
maleadt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please relay back whether the Float16 patch works in the PoCL thread.
partially reverts JuliaPackaging#12219 as otherwise pocl_jll would advertise `Float16` support even though there are almost no builtins present for it, making it pretty useless
No description provided.