Skip to content

Conversation

@simeonschaub
Copy link
Member

No description provided.

@simeonschaub
Copy link
Member Author

Looks like we need a newer GCC version for Float16 support:

[15:42:53] -- Performing Test HOST_COMPILER_SUPPORTS_FLOAT16
[15:42:53] -- Performing Test HOST_COMPILER_SUPPORTS_FLOAT16 - Failed
[15:42:53] -- Host side compiler support for _Float16: 0
[15:42:53] CMake Warning at CMakeLists.txt:930 (message):
[15:42:53]   Note: GCC only supports _Float16 since version 12

@maleadt
Copy link
Member

maleadt commented Oct 14, 2025

Also see pocl/pocl#1943 (reply in thread); that may be a better fix rather than reverting the commit.

Also contains the workaround proposed in pocl/pocl#1943 (reply in thread)
@simeonschaub
Copy link
Member Author

Hmm, now RISC-V is failing, not sure how to fix that

@giordano
Copy link
Member

Maybe https://buildkite.com/julialang/yggdrasil/builds/24118#0199e267-e710-4eb4-946b-349c5f93a12a/1102-1582

[11:29:18] -- LLVMSPIRV library not found: LLVM_SPIRV_INCLUDEDIR-NOTFOUND |
[11:29:18] CMake Warning at cmake/LLVM.cmake:710 (message):
[11:29:19]   udivmodti4 doesn't compile at all!
[11:29:19] Call Stack (most recent call first):
[11:29:19]   CMakeLists.txt:762 (include)

is relevant?

@simeonschaub
Copy link
Member Author

I don't think so. This was the case in https://buildkite.com/julialang/yggdrasil/builds/23892#0199b4b9-a462-4afb-924b-d8f1011e0701/1099-1560 as well and that job passed

@simeonschaub simeonschaub requested a review from maleadt October 15, 2025 10:38
@maleadt maleadt changed the title [pocl] try to reenable Float16 support PoCL: Bump to v7.1 and reenable Float16 support Oct 15, 2025
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please relay back whether the Float16 patch works in the PoCL thread.

@maleadt maleadt merged commit 6ef23a6 into JuliaPackaging:master Oct 15, 2025
27 checks passed
@simeonschaub simeonschaub deleted the sds/pocl_half branch October 17, 2025 11:48
simeonschaub added a commit to simeonschaub/Yggdrasil that referenced this pull request Oct 21, 2025
partially reverts JuliaPackaging#12219 as otherwise pocl_jll would advertise `Float16`
support even though there are almost no builtins present for it, making
it pretty useless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants