Skip to content

CUDA: Update runtime and SDK to v12.8.#10353

Merged
maleadt merged 1 commit intomasterfrom
tb/cuda_runtime_sdk
Jan 27, 2025
Merged

CUDA: Update runtime and SDK to v12.8.#10353
maleadt merged 1 commit intomasterfrom
tb/cuda_runtime_sdk

Conversation

@maleadt
Copy link
Member

@maleadt maleadt commented Jan 27, 2025

No description provided.

@maleadt maleadt added the cuda 🕹️ Builders related to Nvidia CUDA label Jan 27, 2025
@stemann
Copy link
Contributor

stemann commented Jan 27, 2025

Is this the time to add the lib/lib64 symlink: ln -s $prefix/cuda/lib $prefix/cuda/lib64?

@giordano
Copy link
Member

Why? Note that symlinks cause full duplicates on Windows

@maleadt
Copy link
Member Author

maleadt commented Jan 27, 2025

I only added it to the Linux build for that reason, so @stemann maybe you could elaborate why you need that.

@stemann
Copy link
Contributor

stemann commented Jan 27, 2025

Cf. the discussion we had on slack in #binarybuilder - it was needed for the Faiss recipe for CMake to find a functional nvcc - I copied it from the cufinufft recipe.

@maleadt
Copy link
Member Author

maleadt commented Jan 27, 2025

Only having the symlink for Linux seems strictly worse though, because packages will now still need a CMake workaround for some of the platforms.

Alternatively, @giordano, could we still keep the symlink for Windows since the SDK JLLs are typically only installed on Yggdrasil? FWIW, regular CUDA toolkit installations seems to come with it:

❯ ls /opt/cuda -la | grep lib
lrwxrwxrwx 1 root root    5 Nov 21 19:51 lib -> lib64/
lrwxrwxrwx 1 root root   24 Nov 21 19:51 lib64 -> targets/x86_64-linux/lib/

@stemann
Copy link
Contributor

stemann commented Jan 27, 2025

It might also not be the time - if it means that CUDA 12.8+ must be handled differently from CUDA 11.4-12.7. It could also be postponed to sometime when a rebuild of all the SDK versions are needed - though I’m not sure if there is any chance of that happening… (could BB2 trigger a change?)

@maleadt maleadt force-pushed the tb/cuda_runtime_sdk branch from 2b9eeee to 71ec555 Compare January 27, 2025 10:31
@maleadt
Copy link
Member Author

maleadt commented Jan 27, 2025

OK, let's revert it then for now.

@maleadt maleadt merged commit 4c8c297 into master Jan 27, 2025
@maleadt maleadt deleted the tb/cuda_runtime_sdk branch January 27, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda 🕹️ Builders related to Nvidia CUDA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants