Revert "simplify run_interactive, pipeline can now accept an IOBuffer"
#199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
approved these changes
Dec 30, 2021
Member
Author
|
Actually, it might be enough to add BinaryBuilderBase.jl/src/UserNSRunner.jl Line 185 in 385c5e6 |
giordano
added a commit
to giordano/Yggdrasil
that referenced
this pull request
Dec 30, 2021
giordano
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Dec 30, 2021
giordano
added a commit
that referenced
this pull request
Dec 31, 2021
* fix output from runners to IOBuffer * Update test/runners.jl Co-authored-by: Mosè Giordano <[email protected]> * Revert "Revert "simplify `run_interactive`, `pipeline` can now accept an `IOBuffer`" (#199)" This reverts commit 769d8e2. * Add more tests for `run_interactive` Co-authored-by: Mosè Giordano <[email protected]> Co-authored-by: Mosè Giordano <[email protected]>
simeonschaub
pushed a commit
to simeonschaub/Yggdrasil
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #197
This caused some issues (and we need some more tests for this apparently).