support datetimes #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 121 129 +8
=========================================
+ Hits 121 129 +8
☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Oct 2, 2023
Collaborator
|
If we do this, I think we should support Dates for <v1.9 as well (as a direct dependency), via a @static if !isdefined(Base, :get_extension)
include("../ext/DatesExt.jl")
end |
oschulz
reviewed
Oct 2, 2023
Collaborator
|
@aplavin , should we get this one "home"? |
Merged
Contributor
Author
|
Yes I think this is ready |
oschulz
approved these changes
Nov 25, 2023
Collaborator
|
@devmotion any objections to merging and releasing? |
Collaborator
|
My apologies @aplavin , we lost track of this one. @devmotion any objections to merging this? |
Collaborator
|
I'm very sorry for the delay @aplavin ! Merging this now. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.