This repository was archived by the owner on May 23, 2022. It is now read-only.
Merged
Conversation
darsnack
approved these changes
Jul 28, 2021
Member
darsnack
left a comment
darsnack
left a comment
There was a problem hiding this comment.
This and the long term plan for LearnAPI + MLBase sounds good to me
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import
StatsBase: noobsso that downstream packages (such as FastAI.jl) can continue to implementwithout breakage. Since StatsBase is a heavy dependence, I filed JuliaStats/StatsAPI.jl#3 to move
nobsto StatsAPI.jl. Switching from StatsBase to StatsAPI can be done at a later moment without breackage, this PR shouldn't be blocked by that.One tangential consideration: in accordance with these days naming conventions, ideally we should rename
LearnBase -> LearnAPI (a package containing only (unexported) definitions without the implementations, similar to StatsAPI and DataAPI)
MLDataPattens, MLLabelsUtils, LossFunctions, PenatlyFunction could be condensed into a single MLBase package instead.
cc @darsnack