Use custom_isless() to compare all timescales from the user #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some timescale types don't have `isless()` defined between them so `next_datetime_transition()` defined a `custom_isless()` helper to sort them. But it wasn't used when checking for a minimum timescale, causing an exception if the user-requested minimum timescale was a year or month.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some timescale types don't have
isless()defined between them sonext_datetime_transition()defined acustom_isless()helper to sort them. But it wasn't used when checking for a minimum timescale, causing an exception if the user-requested minimum timescale was a year or month.