Skip to content

Conversation

@chriselrod
Copy link
Collaborator

By emitting warnings on loading, Octavian becomes a less appealing dependency for other other packages.

@chriselrod chriselrod requested a review from DilumAluthge April 3, 2021 03:56
@chriselrod chriselrod enabled auto-merge (squash) April 3, 2021 04:13
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #77 (c01a26d) into master (3a95eeb) will decrease coverage by 2.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   85.81%   83.39%   -2.43%     
==========================================
  Files          11       10       -1     
  Lines         578      578              
==========================================
- Hits          496      482      -14     
- Misses         82       96      +14     
Impacted Files Coverage Δ
src/init.jl 68.18% <100.00%> (-8.01%) ⬇️
src/global_constants.jl 46.66% <0.00%> (-20.00%) ⬇️
src/matmul.jl 88.67% <0.00%> (-1.14%) ⬇️
src/Octavian.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a95eeb...c01a26d. Read the comment docs.

@chriselrod chriselrod merged commit 0123f39 into master Apr 3, 2021
@chriselrod chriselrod deleted the nowarn branch April 3, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants