Skip to content

Conversation

@chriselrod
Copy link
Collaborator

const W₁Default = 0.1 # TODO: relax bounds; this was the upper bound set for the optimizer.

These parameter values were found by my Haswell laptop:

const W₁Default = 0.1 # TODO: relax bounds; this was the upper bound set for the optimizer.
const W₂Default = 0.15989396641218157
const R₁Default = 0.4203583148344484
const R₂Default = 0.6344856142604789

Obviously, setting the upper bound to W₁Default at 0.1 was too low. So I'm setting it to 0.2 here.

@chriselrod chriselrod enabled auto-merge (squash) January 24, 2021 14:37
@chriselrod
Copy link
Collaborator Author

We may want to do something like this:
JuliaArrays/OffsetArrays.jl#183

As changing the benchmarks directory or README won't have any impact on any of the tests, so no need to rerun them.
They're not taking 3 hours right now, so it isn't that big of a deal. But something to consider.

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #59 (326889b) into master (d47b39f) will increase coverage by 1.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   41.20%   42.59%   +1.39%     
==========================================
  Files          12       12              
  Lines         716      716              
==========================================
+ Hits          295      305      +10     
+ Misses        421      411      -10     
Impacted Files Coverage Δ
src/init.jl 60.00% <0.00%> (-10.00%) ⬇️
src/matmul.jl 41.56% <0.00%> (-0.42%) ⬇️
src/macrokernels.jl 22.51% <0.00%> (+6.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47b39f...326889b. Read the comment docs.

@chriselrod chriselrod merged commit c968586 into master Jan 24, 2021
@chriselrod chriselrod deleted the chriselrod-patch-1 branch January 24, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants