Skip to content

Conversation

@dkarrasch
Copy link
Member

@dkarrasch dkarrasch commented Nov 8, 2022

Adjusts tests to the generalizations in JuliaLang/julia#47107, which make the tests pass.

Closes #43 and closes #44 by the way.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 85.34% // Head: 85.42% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (68d50a0) compared to base (aa9532a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   85.34%   85.42%   +0.07%     
==========================================
  Files          10       10              
  Lines        1638     1640       +2     
==========================================
+ Hits         1398     1401       +3     
+ Misses        240      239       -1     
Impacted Files Coverage Δ
src/diagonal.jl 84.31% <100.00%> (ø)
src/ldiv.jl 79.62% <100.00%> (+0.38%) ⬆️
src/memorylayout.jl 83.91% <0.00%> (-0.35%) ⬇️
src/factorizations.jl 90.50% <0.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkarrasch dkarrasch merged commit 1d0a09f into master Nov 9, 2022
@dkarrasch dkarrasch deleted the dk/rdivtests branch November 9, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using .\ in copy(::Ldiv{<:DiagonalLayout}) inv.(M.A.diag) .* M.B -> M.A.diag .\ M.B in copy(::Ldiv{<:DiagonalLayout})

2 participants