Add sendfiletoslack function
#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyrodium
commented
Sep 8, 2021
| https://api.slack.com/methods/files.upload | ||
| """ | ||
| function sendfiletoslack(filepath, message, channel, token) | ||
| HTTP.setuseragent!("HTTP.jl") |
Contributor
Author
There was a problem hiding this comment.
I just copied this line from other functions, but was this unnecessary?
Member
There was a problem hiding this comment.
Not 100% sure tbh, I would have to go back and dig around
src/send.jl
Outdated
| end | ||
|
|
||
| """ | ||
| sendfiletoslack(filepath, channel, token) |
Contributor
Author
There was a problem hiding this comment.
I unified the naming convention with that of other functions such as sendtoslack, but I think just sendfile is fine. (And also, I thought it would be better to change sendtoslack -> sendtext, sendattachmenttoslack->sendattachment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11.
Screenshot:
