Skip to content

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 25, 2025

Improves consistency between serial and parallel code and reduces useless log spamming. Logging messages should convey useful content actionable in some form by the user. Neither non-interactive mode nor simple progress meters achieve either goal.

Fix #59527

@vtjnash vtjnash added the backport 1.12 Change should be backported to release-1.12 label Sep 25, 2025
Improves consistency between serial and parallel code and reduces
useless log spamming. Logging messages should convey useful content
actionable in some form by the user. Neither non-interactive mode nor
simple progress meters achieve either goal.

Fix #59527
@vtjnash vtjnash merged commit 42a33bb into master Sep 30, 2025
4 of 7 checks passed
@vtjnash vtjnash deleted the jn/59527 branch September 30, 2025 14:03
@KristofferC KristofferC mentioned this pull request Sep 30, 2025
47 tasks
xal-0 pushed a commit to xal-0/julia that referenced this pull request Sep 30, 2025
Improves consistency between serial and parallel code and reduces
useless log spamming. Logging messages should convey useful content
actionable in some form by the user. Neither non-interactive mode nor
simple progress meters achieve either goal.

Fix JuliaLang#59527
KristofferC pushed a commit that referenced this pull request Oct 10, 2025
Improves consistency between serial and parallel code and reduces
useless log spamming. Logging messages should convey useful content
actionable in some form by the user. Neither non-interactive mode nor
simple progress meters achieve either goal.

Fix #59527

(cherry picked from commit 42a33bb)
KristofferC pushed a commit that referenced this pull request Oct 12, 2025
Improves consistency between serial and parallel code and reduces
useless log spamming. Logging messages should convey useful content
actionable in some form by the user. Neither non-interactive mode nor
simple progress meters achieve either goal.

Fix #59527

(cherry picked from commit 42a33bb)
KristofferC pushed a commit that referenced this pull request Oct 12, 2025
Improves consistency between serial and parallel code and reduces
useless log spamming. Logging messages should convey useful content
actionable in some form by the user. Neither non-interactive mode nor
simple progress meters achieve either goal.

Fix #59527

(cherry picked from commit 42a33bb)
KristofferC pushed a commit that referenced this pull request Oct 15, 2025
Improves consistency between serial and parallel code and reduces
useless log spamming. Logging messages should convey useful content
actionable in some form by the user. Neither non-interactive mode nor
simple progress meters achieve either goal.

Fix #59527

(cherry picked from commit 42a33bb)
@KristofferC
Copy link
Member

I don't know if this was this PR or some other, but it is so annoying that I can't see if a package is precompiling and what is it outputting during precompilation unless I run in interactive mode now. Why wouldn't I want to know if a package precompilation is happening?

It also makes it bad for tools (like an LLM) since it can't look at the precompilation output when running the command.

@vtjnash
Copy link
Member Author

vtjnash commented Oct 17, 2025

Not being able to see output from the package was a "feature" of the original Pkg.precompile code. That is not from this PR.

@KristofferC
Copy link
Member

I used to be able to see them. Now I don't. On 1.12 I see it.

@KristofferC
Copy link
Member

Can we maybe revert these "spam" PRs? I don't see anything better but some things worse.

@vtjnash
Copy link
Member Author

vtjnash commented Oct 17, 2025

We can turn it back on, but it would re-introduce the regression of #59527 (since v1.11) into all our test logs and require yet more work to turn it back off so that tests run silently. There is also work to make precompile faster continuing from this PR in https://github.com/JuliaLang/julia/pull/597650, but I hadn't finished getting the output printing correct there (it fails the newly added tests to prevent further regressions in usability of output)

@IanButterworth
Copy link
Member

I think we need a middle ground. Don't print the Precompiling .... mechanics, but print the output of any explicitly requested packages. i.e. using Foo or precompilepkgs(["Foo"]) as opposed to those added directly from the env graph.

@vtjnash
Copy link
Member Author

vtjnash commented Oct 17, 2025

That should still be printed, as I didn't make any intentional changes to that. It seems there is some work to do to make that doesn't get printed twice for the explicitly requested (that is what the broken test in #597650 is intended to address), and to print at all for indirectly added ones

@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logs getting spammed with "Precompiling" messages

4 participants