-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
remove log spamming from precompilepkg code #59652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improves consistency between serial and parallel code and reduces useless log spamming. Logging messages should convey useful content actionable in some form by the user. Neither non-interactive mode nor simple progress meters achieve either goal. Fix #59527
Improves consistency between serial and parallel code and reduces useless log spamming. Logging messages should convey useful content actionable in some form by the user. Neither non-interactive mode nor simple progress meters achieve either goal. Fix JuliaLang#59527
|
I don't know if this was this PR or some other, but it is so annoying that I can't see if a package is precompiling and what is it outputting during precompilation unless I run in interactive mode now. Why wouldn't I want to know if a package precompilation is happening? It also makes it bad for tools (like an LLM) since it can't look at the precompilation output when running the command. |
|
Not being able to see output from the package was a "feature" of the original |
|
I used to be able to see them. Now I don't. On 1.12 I see it. |
|
Can we maybe revert these "spam" PRs? I don't see anything better but some things worse. |
|
We can turn it back on, but it would re-introduce the regression of #59527 (since v1.11) into all our test logs and require yet more work to turn it back off so that tests run silently. There is also work to make precompile faster continuing from this PR in https://github.com/JuliaLang/julia/pull/597650, but I hadn't finished getting the output printing correct there (it fails the newly added tests to prevent further regressions in usability of output) |
|
I think we need a middle ground. Don't print the |
|
That should still be printed, as I didn't make any intentional changes to that. It seems there is some work to do to make that doesn't get printed twice for the explicitly requested (that is what the broken test in #597650 is intended to address), and to print at all for indirectly added ones |
Improves consistency between serial and parallel code and reduces useless log spamming. Logging messages should convey useful content actionable in some form by the user. Neither non-interactive mode nor simple progress meters achieve either goal.
Fix #59527