unwind: remove upstreamed patch. Fix source build #59641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
added
the
building
giordano
approved these changes
Sep 24, 2025
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
To be clear, the patch was already upstream on the master branch (libunwind/libunwind#887 fixed libunwind/libunwind#873), but in v1.8.3 that patch was also backported to the v1.8 branch, too, so that now we can drop the patch here.
giordano
added
external dependencies
xal-0
pushed a commit
to xal-0/julia
that referenced
this pull request
Sep 30, 2025
Fixes ``` patching file src/ptrace/_UPT_ptrauth_insn_mask.c Hunk JuliaLang#1 FAILED at 49. 1 out of 1 hunk FAILED -- saving rejects to file src/ptrace/_UPT_ptrauth_insn_mask.c.rej make[1]: *** [[buildroot]/deps/unwind.mk:43: [buildroot]/deps/srccache/libunwind-1.8.3/libunwind-missing-parameter-names.patch-applied] Error 1 make[1]: *** Waiting for unfinished jobs.... ``` because the patch was backported to the v1.8 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
because the patch appears to have been upstreamed.