improve inferred effects for reshape for Array

[nsajko]

Use LazyString in throw_dmrsa.

[github-actions]

Hello! I am a bot.

Thank you for your pull request!

I have assigned @LilithHafner to this pull request.

@LilithHafner can either choose to review this pull request themselves, or they can choose to find someone else to review this pull request.

Note: If you are a Julia committer, please make sure that your organization membership is public.

[nsajko]

FTR: the force push just added a @test, as can be seen in the Github Web UI, at least. I want to keep the PR in a single commit to prevent issues with possible backporting. I believe the PR should be backportable to v1.11 and v1.12, and want to fix the effect inference there too. EDIT: it backports cleanly to v1.12.

[nsajko]

Before:

julia> VERSION
v"1.13.0-DEV.720"

julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)

julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)

julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int, Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)

julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int, Int}})
(!c,!e,!n,!t,!s,!m,!u,+o,!r)

After:

julia> VERSION
v"1.13.0-DEV.721"

julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r)

julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r)

julia> Base.infer_effects(reshape, Tuple{Vector{Float32}, Tuple{Int, Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r)

julia> Base.infer_effects(reshape, Tuple{Matrix{Float32}, Tuple{Int, Int}})
(?c,+e,!n,+t,+s,?m,+u,+o,+r)