Skip to content

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 21, 2025

Fix #57358

@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Feb 22, 2025
@KristofferC KristofferC merged commit 88aa27f into master Feb 22, 2025
8 checks passed
@KristofferC KristofferC deleted the jn/57358 branch February 22, 2025 10:59
@oscardssmith
Copy link
Member

Can we get a test added to this?

@KristofferC
Copy link
Member

There are no tests for whether this feature (--strip-metadata) does anything at all so there is no simple incremental test that can be added like that. Doing a strings test on the output artifact of the juliac test is one way to start testing the feature.

KristofferC pushed a commit that referenced this pull request Feb 26, 2025
@topolarity
Copy link
Member

The lack of tests here missed that this regressed the feature (see #57778)

@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--strip-metadata does not strip module file metadata

5 participants