Skip to content

Improve MethodError message for anonymous functions #57340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Improve MethodError message for anonymous functions #57340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b78dc88
Improve error messages for MethodError and add tips for single-method…
Bumblebee00 Feb 9, 2025
3f239d0
Merge branch 'JuliaLang:master' into master
Bumblebee00 Feb 9, 2025
15a0bb4
Merge branch 'JuliaLang:master' into master
Bumblebee00 Feb 10, 2025
92b30c2
splitting in two branches
Bumblebee00 Feb 10, 2025
66f6b7c
Implemented review suggestions
Bumblebee00 Feb 13, 2025
f2113bb
updated the test of this feature
Bumblebee00 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion base/errorshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,9 @@ function showerror(io::IO, ex::MethodError)
curworld = get_world_counter()
print(io, "\nThe applicable method may be too new: running in world age $(ex.world), while current world is $(curworld).")
elseif f isa Function
print(io, "\nThe function `$f` exists, but no method is defined for this combination of argument types.")
print(io, "\nThe ")
isgensym(nameof(f)) && print(io, "anonymous ")
print(io, "function `$f` exists, but no method is defined for this combination of argument types.")
elseif f isa Type
print(io, "\nThe type `$f` exists, but no method is defined for this combination of argument types when trying to construct it.")
else
Expand Down
7 changes: 7 additions & 0 deletions test/errorshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,3 +1262,10 @@ end

f33793(x::Float32, y::Float32) = 1
@test_throws "\nClosest candidates are:\n f33793(!Matched::Float32, !Matched::Float32)\n" f33793(Float64(0.0), Float64(0.0))

# https://github.com/JuliaLang/julia/issues/56325
let err_str
f56325 = x->x+1
err_str = @except_str f56325(1,2) MethodError
@test occursin("The anonymous function", err_str)
end