Bugfix: Convert numbers to Int in extendedterminfo

[jakobnissen]

Before, in the extendedterminfo function in terminfo.jl, if the numbers array was nonempty, the function would fail as a UInt32 cannot be implicitly converted to the output Int type. Do this conversion explicitly.

Closes #51190

@tecosaur it seems that this function was not tested. Looking at code coverage, base/terminfo.jl only has 18% coverage. Would it be possible to test this functionality more thoroughly?

[tecosaur]

Hi Jacob, I've been thinking about #51190 and I have a number of improvements to terminfo.jl worked out, but I haven't been able to figure out what's going on with screen.xterm-256color.

Is this change equivalent to changing NumInt to Int16/Int32? Because I have that as part of my unpushed changes and I still have issues with screen.xterm-256color.

If it helps, here's my WIP-revised terminfo.jl: http://ix.io/4Fre

[tecosaur]

Regarding the supposed 18% code coverage, I'm a bit suspicious of that. It says read(data::IO, ::Type{TermInfoRaw}) is uncalled but we have Base.TermInfo(read(IOBuffer(xterm_terminfo), Base.TermInfoRaw)) in test/terminfo.jl.

[tecosaur]

Oh, I see that #51190 isn't the bug I was thinking of (#51110).

[jakobnissen]

No this bug is much more trivial. The output of extendedterminfo is a Dict{Symbol, Union{Bool, Int, String}}, where the values also include the values of number::Vector{NumInt}. But this fails because you can't convert NumType to the value type of the dict:

julia> Dict{String, Union{Int, String}}("1"=>UInt32(1))
ERROR: MethodError: Cannot `convert` an object of type
  UInt32 to an object of type
  Union{Int64, String}

The real problem is that the function was not tested.

[tecosaur]

In test/terminfo.jl the xterm extended capabilities are tested. They might all be strings though...

[jakobnissen]

Ah I see. Not sure what's up with the coverage then

[tecosaur]

I did think I added it to choosetests.jl correctly...

[tecosaur]

I've now put up my WIP changes as #51198.

[jakobnissen]

Added the merge me label because this is a straightforward bugfix