Skip to content

LinearAlgebra.norm(x::Union{Transpose, Adjoint}) should default to norm(parent(x)) #49020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkarrasch merged 6 commits into from
Mar 22, 2023
Merged

LinearAlgebra.norm(x::Union{Transpose, Adjoint}) should default to norm(parent(x)) #49020

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c011b39
norm of matrix adjoint/transpose falls back to norm of parent
jondeuce Mar 15, 2023
1ab6326
generalize method to all `v::AdjOrTrans`
jondeuce Mar 16, 2023
c8dfc27
add tests to verify `norm(x) == norm(parent(x))`
jondeuce Mar 17, 2023
948f1e9
assert `norm(A') == norm(Matrix(A'))`
jondeuce Mar 20, 2023
743f953
revert `==` back to `isapprox`
jondeuce Mar 21, 2023
8673a79
Update NEWS.md
jondeuce Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/generic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ opnorm(v::AdjointAbsVec, q::Real) = q == Inf ? norm(conj(v.parent), 1) : norm(co
opnorm(v::AdjointAbsVec) = norm(conj(v.parent))
opnorm(v::TransposeAbsVec) = norm(v.parent)

norm(v::Union{TransposeAbsVec,AdjointAbsVec}, p::Real) = norm(v.parent, p)
norm(v::Union{AdjOrTransAbsVec,AdjOrTransAbsMat}, p::Real) = norm(v.parent, p)

"""
dot(x, y)
Expand Down