Skip to content

Initialize the rng of external threads #47956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 2 commits into from
Dec 27, 2022
Merged

Initialize the rng of external threads #47956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f77f8fb
Initialize the rng of external threads with jl_rand()
gbaraldi Dec 21, 2022
ab80c82
Use uv_random since it's safer
gbaraldi Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/threading.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ JL_DLLEXPORT jl_gcframe_t **jl_adopt_thread(void)
// warning: this changes `jl_current_task`, so be careful not to call that from this function
jl_task_t *ct = jl_init_root_task(ptls, stack_lo, stack_hi);
JL_GC_PROMISE_ROOTED(ct);

uv_random(NULL, NULL, &ct->rngState, sizeof(ct->rngState), 0, NULL);
return &ct->gcstack;
}

Expand Down