Provider cycleclock() for 32bit ARM targets #47358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
building
ararslan
reviewed
Nov 9, 2022
fingolfin
force-pushed
the
mh/arm-cycleclock
branch
from
f4dac1c to
c28c4d1
Compare
fingolfin
force-pushed
the
mh/arm-cycleclock
branch
from
c28c4d1 to
34cd3ab
Compare
ararslan
approved these changes
Nov 10, 2022
Member
ararslan
left a comment
ararslan
left a comment
There was a problem hiding this comment.
I don't have a 32-bit ARM system handy to verify myself but if it resolves the issue for you and doesn't obviously cause any others, this looks good to me. It correctly adjusts the C++ static_cast to a regular C cast and otherwise matches the linked code.
51 tasks
Member
Author
|
Merge please? |
KristofferC
pushed a commit
that referenced
this pull request
Dec 8, 2022
Based on https://github.com/google/benchmark/blob/main/src/cycleclock.h (cherry picked from commit 060a492)
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/google/benchmark/blob/main/src/cycleclock.h
Resolves #47347