atomics: tweak [modify|swap]property! docs
#46983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Sep 30, 2022
| `getfield` expression and is modified atomically. | ||
| The syntax `@atomic op(x.f, v)` (and its equivalent `@atomic x.f op v`) returns | ||
| `modifyproperty!(x, :f, op, v, :sequentially_consistent)`, where the first argument | ||
| must be a `getproperty` expression and is modified atomically. |
Member
There was a problem hiding this comment.
swapproperty! also calls it a getfield expression
Member
Author
There was a problem hiding this comment.
Do you want to keep calling it getfield expression?
Member
There was a problem hiding this comment.
Either way, just as long as we are consistent
Member
Author
There was a problem hiding this comment.
Okay, let's go with getproperty then. I think getproperty is more familiar with general users.
aviatesk
force-pushed
the
avi/modifypropety-docs
branch
from
21b703d to
c55b34f
Compare
aviatesk
changed the title
modifyproperty! docs[modify|swap]property! docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.