-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Clarify non-Unicode Korean tests #45815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This, combined with a rootfs image bump including the bits from JuliaCI/rootfs-images#208 will help us to silence CI warnings such as https://buildkite.com/julialang/julia-master/builds/13227#01819c05-81fc-4bd9-bb58-7f7872193d6c/560-843 |
|
This would sort of defeat the comment there which says not to use Unicode here |
|
I was confused by that comment, because the output of our tests seems to be identical across every korean locale I can find: This was generated with a If we're wanting to test codepoint output that is explicitly not UTF-8, I think we need a different test, because these all output the exact same UTF-8. |
|
yes, exact equivalence would be rather the point of the test (#27273) |
5a743a8 to
bded0be
Compare
ko_KR.UTF-8 locale as wellAdd explanation and extra tests to ensure that our non-unicode transcription works properly and outputs a reasonable UTF-8 string. Note that on musl, `setlocales()` never fails, and so we cannot test this properly.
bded0be to
c78a8db
Compare
|
Alright, I've switched this PR to instead clarify some things and adds tests (where appropriate) to ensure that we don't just get |
|
Confirmed working. Compare the previous Versus this build: Windows builds also seem good. |
|
@vtjnash Does this look better now? Thanks for helping me to understand the purpose behind this test. I've done my best to encode that in comments in the source as well. |
This is the recommended locale by Arch Linux, so let's look for it as
well