make length(StepRange()) type stable
#45236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N5N3
reviewed
May 9, 2022
Moelf
force-pushed
the
length_range_typestability
branch
from
850d7a9 to
937a25c
Compare
oscardssmith
approved these changes
May 11, 2022
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
May 11, 2022
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
May 12, 2022
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
May 12, 2022
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
May 17, 2022
N5N3
added a commit
to N5N3/julia
that referenced
this pull request
Jul 25, 2022
vtjnash
added a commit
that referenced
this pull request
Aug 10, 2022
* Follow up to #45236 (make `length(::StepRange{Int8,Int128})` type-stable) * Fully drop `_tuple_any` (unneeded now) * Make sure `has_offset_axes(::StepRange)` could be const folded. And define some "cheap" `firstindex` * Do offset axes check on `A`'s parent rather than itself. This avoid some unneeded `axes` call, thus more possible be folded by the compiler. Co-authored-by: Jameson Nash <[email protected]>
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
* Follow up to JuliaLang#45236 (make `length(::StepRange{Int8,Int128})` type-stable) * Fully drop `_tuple_any` (unneeded now) * Make sure `has_offset_axes(::StepRange)` could be const folded. And define some "cheap" `firstindex` * Do offset axes check on `A`'s parent rather than itself. This avoid some unneeded `axes` call, thus more possible be folded by the compiler. Co-authored-by: Jameson Nash <[email protected]>
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
* Follow up to JuliaLang#45236 (make `length(::StepRange{Int8,Int128})` type-stable) * Fully drop `_tuple_any` (unneeded now) * Make sure `has_offset_axes(::StepRange)` could be const folded. And define some "cheap" `firstindex` * Do offset axes check on `A`'s parent rather than itself. This avoid some unneeded `axes` call, thus more possible be folded by the compiler. Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #45232