base/version_git.sh: fix the default value for Base.GIT_VERSION_INFO (for e.g. when Git is not available)
#43717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
added
building
DilumAluthge
changed the title
Base.@kwdef to automatically provide a kwarg constructor for the GitVersionInfo struct with default valuesbase/version_git.sh: provide a kwarg constructor (with default values) for the GitVersionInfo struct
DilumAluthge
changed the title
base/version_git.sh: provide a kwarg constructor (with default values) for the GitVersionInfo structbase/version_git.sh: fix the default constructor for the GitVersionInfo struct
DilumAluthge
changed the title
base/version_git.sh: fix the default constructor for the GitVersionInfo structbase/version_git.sh: fix the default value for Base.GIT_VERSION_INFO (for e.g. when Git is not available)
DilumAluthge
force-pushed
the
dpa/git-version-info
branch
from
677df48 to
401d5b6
Compare
…FO` (for e.g. when Git is not available)
DilumAluthge
force-pushed
the
dpa/git-version-info
branch
from
d010310 to
f7c48c9
Compare
|
@DilumAluthge + @mkitti thanks for this! We are working on having a more robust packaging system downstream by doing regular dev releases to test breaking changes from "system packages" (see conda-forge/julia-feedstock#181) and this is quite helpful |
staticfloat
approved these changes
Jan 9, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…FO` (for e.g. when Git is not available) (JuliaLang#43717) * `base/version_git.sh`: fix the default value for `Base.GIT_VERSION_INFO` (for e.g. when Git is not available) * Use single-quotes to avoid the need to backslash-escape the double quotes
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…FO` (for e.g. when Git is not available) (JuliaLang#43717) * `base/version_git.sh`: fix the default value for `Base.GIT_VERSION_INFO` (for e.g. when Git is not available) * Use single-quotes to avoid the need to backslash-escape the double quotes
DilumAluthge
added
backport 1.6
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43716