Use the module specific names in names() instead of the binding
#42532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Oct 7, 2021
JeffBezanson
approved these changes
Oct 7, 2021
Member
|
Thanks, very helpful first PR! |
fredrikekre
added
backport 1.6
84 tasks
This was referenced Oct 19, 2021
KristofferC
force-pushed
the
aliased_bindings_42527
branch
from
cca058f to
dec1727
Compare
Member
|
Rebased to get another CI run. |
DilumAluthge
removed
the
merge me
KristofferC
removed
backport 1.6
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #42527, the imported values that are aliased have their original name as
binding->name(unlike the modules). However, the key of the binding table has the relevant name so this can be used in thenamesfunction to always get the aliased version.Fixes #42527