Skip to content

Conversation

@DilumAluthge
Copy link
Member

Normally, we always pass the code coverage job.

However, if the coverage is suspiciously low (e.g. less than 50%), then this suggests that something went wrong earlier in the coverage job. Therefore, in those cases, we should fail the build to indicate that something has gone wrong somewhere in the code coverage pipeline.

@DilumAluthge DilumAluthge added ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 11, 2021
@DilumAluthge DilumAluthge requested a review from a team as a code owner September 11, 2021 01:27
@DilumAluthge DilumAluthge removed the request for review from a team September 11, 2021 01:27
@DilumAluthge
Copy link
Member Author

@DilumAluthge DilumAluthge changed the title CI (Buildkite, code coverage): Fail the code coverage job is the coverage is suspiciously low CI (Buildkite, code coverage): Fail the code coverage job if the coverage is suspiciously low Sep 11, 2021
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #42213 (92a3a07) into master (1709f79) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42213      +/-   ##
==========================================
+ Coverage   89.26%   89.28%   +0.02%     
==========================================
  Files         351      351              
  Lines       78670    78664       -6     
==========================================
+ Hits        70222    70239      +17     
+ Misses       8448     8425      -23     
Impacted Files Coverage Δ
base/secretbuffer.jl 97.82% <0.00%> (-2.18%) ⬇️
base/binaryplatforms.jl 81.76% <0.00%> (-1.52%) ⬇️
stdlib/LibGit2/src/gitcredential.jl 96.50% <0.00%> (-1.40%) ⬇️
stdlib/LibGit2/src/merge.jl 87.09% <0.00%> (-1.08%) ⬇️
base/path.jl 68.29% <0.00%> (-0.98%) ⬇️
base/filesystem.jl 90.35% <0.00%> (-0.88%) ⬇️
base/bitset.jl 93.19% <0.00%> (-0.86%) ⬇️
stdlib/LibGit2/src/LibGit2.jl 82.94% <0.00%> (-0.67%) ⬇️
base/file.jl 82.10% <0.00%> (-0.57%) ⬇️
stdlib/Random/src/generation.jl 92.88% <0.00%> (-0.45%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7028da...92a3a07. Read the comment docs.

@DilumAluthge
Copy link
Member Author

The coverage build (https://buildkite.com/julialang/julia-master-scheduled/builds/234) passed.

@DilumAluthge DilumAluthge merged commit e65296f into master Sep 11, 2021
@DilumAluthge DilumAluthge deleted the dpa/coverage-red-flag branch September 11, 2021 04:29
KristofferC pushed a commit that referenced this pull request Sep 11, 2021
…rage is suspiciously low (#42213)

(cherry picked from commit e65296f)
KristofferC pushed a commit that referenced this pull request Sep 15, 2021
…rage is suspiciously low (#42213)

(cherry picked from commit e65296f)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
…rage is suspiciously low (#42213)

(cherry picked from commit e65296f)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
…rage is suspiciously low (#42213)

(cherry picked from commit e65296f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants