bugfix: properly import Base.cis into LinearAlgebra #42164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain methods, e.g.,
`cis(::Union{RealHermSymComplexHerm,SymTridiagonal{<:Real}})`,
were not imported properly.
ararslan
added
backport 1.7
bugfix
ararslan
approved these changes
Sep 10, 2021
KristofferC
pushed a commit
that referenced
this pull request
Sep 11, 2021
Certain methods, e.g.,
`cis(::Union{RealHermSymComplexHerm,SymTridiagonal{<:Real}})`,
were not imported properly.
(cherry picked from commit c4f0d8b)
16 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Certain methods, e.g.,
`cis(::Union{RealHermSymComplexHerm,SymTridiagonal{<:Real}})`,
were not imported properly.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Certain methods, e.g.,
`cis(::Union{RealHermSymComplexHerm,SymTridiagonal{<:Real}})`,
were not imported properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes JuliaLang/LinearAlgebra.jl#865 (
cis(::Union{RealHermSymComplexHerm,SymTridiagonal{<:Real}})not properly exported fromLinearAlgebra.)For the changes to take effect,
Revise.revise()seemed to be insufficient, but rebuilding julia withmakeworked. Perhaps it has something to do with the sysimage?Also not sure if additional regression tests should be added, or if this kind of bug should be avoided by checking the coverage reports?