Use unwrapva in MethodError candidates
#42161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found an example of a method declaration with an argument
typed as `a::Vararg`, and this triggered an error in showing method
candidates. It's always bad when there's an error triggered when handling
an error. This PR makes the code more robust against such problems.
It's worth noting that this type of method declaration
shouldn't be used: it is better as `a...`. The only time you should
explicitly use `Vararg` is when you are specifying both `T` and
`N` in `Vararg{T,N}`.
timholy
added a commit
to JuliaArrays/OffsetArrays.jl
that referenced
this pull request
Sep 8, 2021
Shorter, more readable, and doesn't break Julia. What's not to like? xref JuliaLang/julia#42161
vtjnash
approved these changes
Sep 8, 2021
Member
|
@Keno Do we need to keep the undef property for |
timholy
commented
Sep 8, 2021
Member
I think it's probably fine to normalize inside |
Member
|
Does it appear anywhere else? |
DilumAluthge
removed
the
merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
I found an example of a method declaration with an argument
typed as `a::Vararg`, and this triggered an error in showing method
candidates. It's always bad when there's an error triggered when handling
an error. This PR makes the code more robust against such problems.
It's worth noting that this type of method declaration
shouldn't be used: it is better as `a...`. The only time you should
explicitly use `Vararg` is when you are specifying both `T` and
`N` in `Vararg{T,N}`.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
I found an example of a method declaration with an argument
typed as `a::Vararg`, and this triggered an error in showing method
candidates. It's always bad when there's an error triggered when handling
an error. This PR makes the code more robust against such problems.
It's worth noting that this type of method declaration
shouldn't be used: it is better as `a...`. The only time you should
explicitly use `Vararg` is when you are specifying both `T` and
`N` in `Vararg{T,N}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an example of a method declaration with an argument
typed as
a::Vararg, and this triggered an error in showing methodcandidates. It's always bad when there's an error triggered when handling
an error. This PR makes the code more robust against such problems.
It's worth noting that this type of method declaration
shouldn't be used: it is better as
a.... The only time you shouldexplicitly use
Varargis when you are specifying bothTandNinVararg{T,N}.