Skip to content

Allow AbstractUnitRange for string getindex #41807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vtjnash merged 3 commits into from
Aug 18, 2021
Merged

Allow AbstractUnitRange for string getindex #41807

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00dbba9
Allow AbstractUnitRange for string getindex
mkitti Aug 6, 2021
04d0012
Inlined String getindex should use UnitRange{Int}
mkitti Aug 6, 2021
c62a799
Generalize getindex for AbstractString, resolve method ambiguity
mkitti Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/strings/string.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ function getindex_continued(s::String, i::Int, u::UInt32)
return reinterpret(Char, u)
end

getindex(s::String, r::UnitRange{<:Integer}) = s[Int(first(r)):Int(last(r))]
getindex(s::String, r::AbstractUnitRange{<:Integer}) = s[Int(first(r)):Int(last(r))]

@inline function getindex(s::String, r::UnitRange{Int})
isempty(r) && return ""
Expand Down