Skip to content

REPL doc lookup assumed ASCII for the given string #41594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2021
Merged

REPL doc lookup assumed ASCII for the given string #41594

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f26a592
Fix indexing in doc lookup
Seelengrab Jul 15, 2021
4f9ae2a
Add tests for UTF-8 doc lookup
Seelengrab Jul 15, 2021
ee1c62e
Apply suggestions from code review
fredrikekre Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/REPL/src/docview.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ function lookup_doc(ex)
str = string(ex)
isdotted = startswith(str, ".")
if endswith(str, "=") && Base.operator_precedence(ex) == Base.prec_assignment && ex !== :(:=)
op = str[1:end-1]
op = str[begin:prevind(str, lastindex(str))]
eq = isdotted ? ".=" : "="
return Markdown.parse("`x $op= y` is a synonym for `x $eq x $op y`")
elseif isdotted && ex !== :(..)
Expand Down
6 changes: 6 additions & 0 deletions stdlib/REPL/test/docview.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,9 @@ end
# shouldn't throw when there is a space in a middle of query
@test (REPL.matchinds("a ", "a file.txt"); true)
end

@testset "Unicode doc lookup" begin
# https://github.com/JuliaLang/julia/issues/41589
# assuming ASCII is bad, m'kay?
@test REPL.lookup_doc(:(÷=)) isa Markdown.MD
end