Skip to content

make failure to precompile a method return a value instead of a unconditionally warn #41447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2021
Merged

make failure to precompile a method return a value instead of a unconditionally warn #41447

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
899a609
make failure to precompile a method a emit a debug log instead of a warn
KristofferC Jul 2, 2021
2ee1fc4
Update base/loading.jl
KristofferC Jul 2, 2021
06a31a0
fix return value of precompile
KristofferC Jul 2, 2021
f64aecd
go back to 1.6 version of precompile
KristofferC Aug 10, 2021
deaeec7
Update base/loading.jl
KristofferC Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,7 +1928,7 @@ end

function precompile(argt::Type)
if ccall(:jl_compile_hint, Int32, (Any,), argt) == 0
@warn "Inactive precompile statement" maxlog=100 form=argt _module=nothing _file=nothing _line=0
@debug "Inactive precompile statement" form=argt _module=nothing _file=nothing _line=0
end
true
end
Expand Down