AbstractInterpreter: refactor abstract_call_method -> abstract_call_method_with_const_args chain
#41020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_call_method_with_const_args` chain This PR refactors the `abstract_call_method` -> `abstract_call_method_with_const_args` chain, and simplifies the signature of `abstract_call_method_with_const_args`: the newly defined `MethodCallResult` struct wraps a result and context information of `abstract_method_call`, and is passed and consumed by the succeeding `abstract_call_method_with_const_args`. Although our constant-propagation heuristic will be likely to change in the future (as in #40561) and so the signature of `abstract_call_method_with_const_args` is very unstable, hopefully this PR makes it a bit more stable. As an additional benefit, now an external `AbstractInterpreter` can use the context information of `abstract_method_call` (especially `edge::MethodInstance`) within `maybe_get_const_prop_profitable`.
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
May 31, 2021
aviatesk
changed the title
abstract_call_method -> abstract_call_method_with_const_args chainabstract_call_method -> abstract_call_method_with_const_args chain
aviatesk
added a commit
to aviatesk/JET.jl
that referenced
this pull request
Jun 1, 2021
Will be followed up by #207
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
…_call_method_with_const_args` chain (JuliaLang#41020) This PR refactors the `abstract_call_method` -> `abstract_call_method_with_const_args` chain, and simplifies the signature of `abstract_call_method_with_const_args`: the newly defined `MethodCallResult` struct wraps a result and context information of `abstract_method_call`, and is passed and consumed by the succeeding `abstract_call_method_with_const_args`. Although our constant-propagation heuristic will be likely to change in the future (as in JuliaLang#40561) and so the signature of `abstract_call_method_with_const_args` is very unstable, hopefully this PR makes it a bit more stable. As an additional benefit, now an external `AbstractInterpreter` can use the context information of `abstract_method_call` (especially `edge::MethodInstance`) within `maybe_get_const_prop_profitable`.
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…_call_method_with_const_args` chain (JuliaLang#41020) This PR refactors the `abstract_call_method` -> `abstract_call_method_with_const_args` chain, and simplifies the signature of `abstract_call_method_with_const_args`: the newly defined `MethodCallResult` struct wraps a result and context information of `abstract_method_call`, and is passed and consumed by the succeeding `abstract_call_method_with_const_args`. Although our constant-propagation heuristic will be likely to change in the future (as in JuliaLang#40561) and so the signature of `abstract_call_method_with_const_args` is very unstable, hopefully this PR makes it a bit more stable. As an additional benefit, now an external `AbstractInterpreter` can use the context information of `abstract_method_call` (especially `edge::MethodInstance`) within `maybe_get_const_prop_profitable`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
abstract_call_method->abstract_call_method_with_const_argschain, and simplifies the signature of
abstract_call_method_with_const_args:the newly defined
MethodCallResultstruct wraps a result and contextinformation of
abstract_method_call, and is passed and consumedby the succeeding
abstract_call_method_with_const_args.Although our constant-propagation heuristic will be likely to change in
the future (as in #40561) and so the signature of
abstract_call_method_with_const_argsis very unstable, hopefully this PR makes it a bit more stable.
As an additional benefit, now an external
AbstractInterpretercan usethe context information of
abstract_method_call(especiallyedge::MethodInstance)within
maybe_get_const_prop_profitable.