Add tests for indexing arrays with IdentityUnitRanges #40657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
changed the title
jishnub
changed the title
simeonschaub
approved these changes
Apr 29, 2021
Member
simeonschaub
left a comment
simeonschaub
left a comment
There was a problem hiding this comment.
Small indentation nit, but otherwise LGTM.
vtjnash
force-pushed
the
offsetvectorindexing
branch
from
5cefdcd to
1b54669
Compare
Member
|
Tried to merge this, but the tests failed. See commit message of 1b54669 |
Member
|
Possibly broken by #40660? |
jishnub
force-pushed
the
offsetvectorindexing
branch
from
1b54669 to
77057c3
Compare
Member
Author
|
Indeed, should be fixed now. Tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests with
Base.IdentityUnitRangewere missed out in #39896, would be good to include these as well