Skip to content

Fix showindices for IdentityUnitRange #40608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix showindices for IdentityUnitRange #40608

merged 1 commit into from
Apr 28, 2021

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Apr 26, 2021

IdentityUnitRange should not be displayed as : in the summary of SubArrays.

On master

julia> @view ones(2)[Base.IdentityUnitRange(2:2)]
1-element view(::Vector{Float64}, :) with eltype Float64 with indices 2:2:
 1.0

After this PR

julia> @view ones(2)[Base.IdentityUnitRange(2:2)]
1-element view(::Vector{Float64}, Base.IdentityUnitRange(2:2)) with eltype Float64 with indices 2:2:
 1.0

simeonschaub
simeonschaub approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was introduced unintentionally in #28941.

@simeonschaub simeonschaub requested a review from mbauman April 26, 2021 12:33
@simeonschaub simeonschaub added backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug display and printing Aesthetics and correctness of printed representations of objects. labels Apr 26, 2021
@simeonschaub simeonschaub merged commit e9ef280 into JuliaLang:master Apr 28, 2021
@jishnub jishnub deleted the viewIdentityUnitRange branch April 28, 2021 09:54
@KristofferC KristofferC mentioned this pull request May 4, 2021
Merged
45 tasks
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@jishnub @ElOceanografo
Fix showindices for IdentityUnitRange (JuliaLang#40608)
a246803
jarlebring pushed a commit to jarlebring/julia that referenced this pull request May 4, 2021
@jishnub @jarlebring
Fix showindices for IdentityUnitRange (JuliaLang#40608)
44cad18
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@jishnub @antoine-levitt
Fix showindices for IdentityUnitRange (JuliaLang#40608)
e0599be
KristofferC pushed a commit that referenced this pull request May 11, 2021
@jishnub @KristofferC
Fix showindices for IdentityUnitRange (#40608)
3267f48 
(cherry picked from commit e9ef280)
KristofferC pushed a commit that referenced this pull request May 12, 2021
@jishnub @KristofferC
Fix showindices for IdentityUnitRange (#40608)
1ce1103 
(cherry picked from commit e9ef280)
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@jishnub @johanmon
Fix showindices for IdentityUnitRange (JuliaLang#40608)
5b07ef9
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@jishnub @staticfloat
Fix showindices for IdentityUnitRange (#40608)
dc37dc1 
(cherry picked from commit e9ef280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simeonschaub simeonschaub simeonschaub approved these changes

@mbauman mbauman Awaiting requested review from mbauman

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug display and printing Aesthetics and correctness of printed representations of objects.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jishnub @simeonschaub @KristofferC