[cli] Provide .type and .size annotations for symbols
#40575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ELF platforms, `ld` can print out warnings that certain symbols do not have a type or size annotation. This adds the annotations to the `DEBUGINFO` and `EXPORT` helper macros, which are where this information was put for the windows assembler. With this patch, we should eliminate `ld` warnings such as: ``` warning: type and size of dynamic symbol `jl_symbol' are not defined ```
Member
Author
|
Confirmed working in #40524 |
Member
|
Possibly needs some cleanup of the ppc/arm/AArch64 trampoline files too to apply this? |
KristofferC
pushed a commit
that referenced
this pull request
May 4, 2021
On ELF platforms, `ld` can print out warnings that certain symbols do not have a type or size annotation. This adds the annotations to the `DEBUGINFO` and `EXPORT` helper macros, which are where this information was put for the windows assembler. With this patch, we should eliminate `ld` warnings such as: ``` warning: type and size of dynamic symbol `jl_symbol' are not defined ``` (cherry picked from commit ac7974a)
45 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…40575) On ELF platforms, `ld` can print out warnings that certain symbols do not have a type or size annotation. This adds the annotations to the `DEBUGINFO` and `EXPORT` helper macros, which are where this information was put for the windows assembler. With this patch, we should eliminate `ld` warnings such as: ``` warning: type and size of dynamic symbol `jl_symbol' are not defined ```
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…40575) On ELF platforms, `ld` can print out warnings that certain symbols do not have a type or size annotation. This adds the annotations to the `DEBUGINFO` and `EXPORT` helper macros, which are where this information was put for the windows assembler. With this patch, we should eliminate `ld` warnings such as: ``` warning: type and size of dynamic symbol `jl_symbol' are not defined ```
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
…40575) On ELF platforms, `ld` can print out warnings that certain symbols do not have a type or size annotation. This adds the annotations to the `DEBUGINFO` and `EXPORT` helper macros, which are where this information was put for the windows assembler. With this patch, we should eliminate `ld` warnings such as: ``` warning: type and size of dynamic symbol `jl_symbol' are not defined ```
staticfloat
added a commit
to JuliaLinearAlgebra/libblastrampoline
that referenced
this pull request
Sep 28, 2022
We needed to do this for the trampolines in Julia as well. X-ref: JuliaLang/julia#40575
staticfloat
added a commit
to JuliaLinearAlgebra/libblastrampoline
that referenced
this pull request
Sep 28, 2022
We needed to do this for the trampolines in Julia as well. X-ref: JuliaLang/julia#40575
staticfloat
added a commit
to JuliaLinearAlgebra/libblastrampoline
that referenced
this pull request
Sep 28, 2022
We needed to do this for the trampolines in Julia as well. X-ref: JuliaLang/julia#40575
staticfloat
added a commit
that referenced
this pull request
Dec 23, 2022
On ELF platforms, `ld` can print out warnings that certain symbols do not have a type or size annotation. This adds the annotations to the `DEBUGINFO` and `EXPORT` helper macros, which are where this information was put for the windows assembler. With this patch, we should eliminate `ld` warnings such as: ``` warning: type and size of dynamic symbol `jl_symbol' are not defined ``` (cherry picked from commit ac7974a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ELF platforms,
ldcan print out warnings that certain symbols donot have a type or size annotation. This adds the annotations to the
DEBUGINFOandEXPORThelper macros, which are where this informationwas put for the windows assembler. With this patch, we should eliminate
ldwarnings such as: